Optimize settings and node selector hooks#1001
Draft
KingParmenides wants to merge 3 commits intoeigenwallet:masterfrom
Draft
Optimize settings and node selector hooks#1001KingParmenides wants to merge 3 commits intoeigenwallet:masterfrom
KingParmenides wants to merge 3 commits intoeigenwallet:masterfrom
Conversation
|
Per our AI policy we require all communication to be exclusively human written. Until this requirement is met, we can't spare the effort to review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSettingsanduseNodessubscribe to the selected value instead of the whole Redux slice.shallowEqualso selectors returning small arrays/objects stay stable across unrelated store updates.Refs #727.
Verification
COREPACK_HOME=/private/tmp/codex-corepack-cache YARN_GLOBAL_FOLDER=/private/tmp/codex-yarn-global YARN_CACHE_FOLDER=/private/tmp/codex-yarn-cache npx corepack yarn eslint src/store/hooks.ts src/store/selectors.ts --quietgit diff --checkNote
npx corepack yarn tsc --noEmitis blocked in this fresh checkout because generatedsrc/models/tauriModel.tsis absent.If this is accepted for the XMR bounty, I can provide the payout address.