Skip to content

Optimize settings and node selector hooks#1001

Draft
KingParmenides wants to merge 3 commits intoeigenwallet:masterfrom
KingParmenides:optimize-settings-node-selectors
Draft

Optimize settings and node selector hooks#1001
KingParmenides wants to merge 3 commits intoeigenwallet:masterfrom
KingParmenides:optimize-settings-node-selectors

Conversation

@KingParmenides
Copy link
Copy Markdown

@KingParmenides KingParmenides commented May 11, 2026

Summary

  • Make useSettings and useNodes subscribe to the selected value instead of the whole Redux slice.
  • Use shallowEqual so selectors returning small arrays/objects stay stable across unrelated store updates.
  • Move pending approval subtype filters into memoized selectors so shared modal/alert hooks reuse stable arrays.
  • Memoize pending background process and Bitcoin sync progress derivations, including conservative aggregate sync progress.

Refs #727.

Verification

  • COREPACK_HOME=/private/tmp/codex-corepack-cache YARN_GLOBAL_FOLDER=/private/tmp/codex-yarn-global YARN_CACHE_FOLDER=/private/tmp/codex-yarn-cache npx corepack yarn eslint src/store/hooks.ts src/store/selectors.ts --quiet
  • git diff --check

Note

  • npx corepack yarn tsc --noEmit is blocked in this fresh checkout because generated src/models/tauriModel.ts is absent.

If this is accepted for the XMR bounty, I can provide the payout address.

@Einliterflasche
Copy link
Copy Markdown

Per our AI policy we require all communication to be exclusively human written. Until this requirement is met, we can't spare the effort to review this.

@Einliterflasche Einliterflasche marked this pull request as draft May 11, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants