Skip to content

Fix broken swap-core unit tests#991

Open
dicnunz wants to merge 1 commit intoeigenwallet:masterfrom
dicnunz:fix-broken-unit-tests-724
Open

Fix broken swap-core unit tests#991
dicnunz wants to merge 1 commit intoeigenwallet:masterfrom
dicnunz:fix-broken-unit-tests-724

Conversation

@dicnunz
Copy link
Copy Markdown

@dicnunz dicnunz commented May 9, 2026

Summary

  • Forward the test-only static-fee wallet trait methods to the real wallet implementation instead of panicking in swap-core tests.
  • Update the Monero overflow assertion to match the current Amount::parse_monero error shape.

Reproduction

On current master, cargo test -p swap-core -p swap-feed -p swap-orchestrator reached swap-core and failed seven tests: the TxLock/funding tests hit the static-fee wallet stub, and parse_monero_overflows tried to downcast the current parser error into an old local OverflowError type.

Tests

  • cargo fmt --all
  • git diff --check
  • cargo test -p swap-core --lib
  • cargo test -p swap-core -p swap-feed -p swap-orchestrator
  • cargo test -p bitcoin-wallet

I also attempted cargo test -p swap -p swap-asb; after initializing submodules and installing missing local cmake, it continued into the native Monero/Boost depends build and was stopped before Rust test execution because that path was no longer the shortest proof for this patch.

Bounty

Refs #724 / bounty: 0.25 XMR.

AI assistance

AI assistance was used for investigation and patch drafting; the changes above were inspected and verified with the listed local commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant