Optimize conversation unread message selectors#993
Draft
onuraycicek wants to merge 1 commit intoeigenwallet:masterfrom
Draft
Optimize conversation unread message selectors#993onuraycicek wants to merge 1 commit intoeigenwallet:masterfrom
onuraycicek wants to merge 1 commit intoeigenwallet:masterfrom
Conversation
|
Per our AI policy we require all communication to be exclusively human written. Until this requirement is met, we can't spare the effort to review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setinstances and wrapper objects insideuseAppSelectorfor unread conversation counts.[]selector result.Why
This targets the UI performance bounty in #727. The previous selectors returned new references on every Redux update even when
conversationsandseenMessageswere unchanged, which makes React-Redux treat the selected value as changed and re-render subscribers unnecessarily.Testing
corepack yarn tsccorepack yarn eslint src/store/hooks.ts src/renderer/components/pages/help/ConversationsBox.tsx --quiet