fix(monero-sys): avoid wallet listener handle cycles#999
Draft
copp1723 wants to merge 4 commits intoeigenwallet:masterfrom
Draft
fix(monero-sys): avoid wallet listener handle cycles#999copp1723 wants to merge 4 commits intoeigenwallet:masterfrom
copp1723 wants to merge 4 commits intoeigenwallet:masterfrom
Conversation
|
Per our AI policy we require all communication to be exclusively human written. Until this requirement is met, we can't spare the effort to review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #695
Summary
WalletHandleListenerandTauriWalletListenercaptures toWeak.balance_per_subaddressinstead of panicking if the wallet channel is closed.Why
The #695 logs show wallet callbacks queueing
store_in_current_file/ refresh work around a closed channel, then panicking on closed-channel sends. Weak captures keep callback work tied to live handles only, and the remaining subaddress balance helper now propagates the closed-channel error like the rest of the wallet API.Verification
git diff --checkRUSTUP_TOOLCHAIN=stable cargo fmt --checkcargo checknot fully run locally:monero-sysbuild script requires the Monero C++ source/submodule and stopped atTarget file src/wallet/api/wallet.cpp not found