Skip to content

fix: sync reproducibility artifacts for v3.2.1 registry#117

Merged
munkyukim86 merged 1 commit into
mainfrom
fix/sync-repro-artifacts-v321
Jun 17, 2026
Merged

fix: sync reproducibility artifacts for v3.2.1 registry#117
munkyukim86 merged 1 commit into
mainfrom
fix/sync-repro-artifacts-v321

Conversation

@munkyukim86

Copy link
Copy Markdown
Contributor

Summary

  • update the benchmark reproducibility MANIFEST parameter_registry SHA-256 to match the current v3.2.1 registry file
  • refresh the worked example design package registry hash
  • recompute worked example output MANIFEST hashes from normalized committed bytes

Verification

  • python -m pytest tests/test_docs_consistency.py::test_manifest_input_sha256_matches_files tests/test_worked_example.py::test_run_example_deterministic -q
  • python -m pytest tests/test_docs_consistency.py tests/test_worked_example.py -q
  • python -m pytest -q

Local result: 589 passed, 1 skipped.

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
factorforge-cds Ready Ready Preview, Comment Jun 17, 2026 7:35am

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d38f82a538

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"parameter_registry": {
"path": "src/factorforge/registry/current_parameter_registry.yaml",
"sha256": "da95907eced327f90eb463e359f87f316bf2bffbb29b022ee3656b79905e40e2"
"sha256": "849cbdc8f60b71543dd95b9018ecfc02f16265797549ceaa0800ddf8c029f37f"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pin the v3.2.0 benchmark manifest to its registry

When users verify or reproduce this benchmark_v0.5.1 evidence pack, the same manifest still declares factorforge_version/archive version 3.2.0 and pins git_commit to 6409108921d538396b67c7edd3434b43e547f666; the registry file at that commit hashes to the previous da959... value, not this new current-3.2.1 hash. Updating only this SHA makes the manifest describe parameters that were not present in the pinned software release, so verification against the recorded commit fails or misattributes the benchmark run; keep this entry tied to the recorded release/commit, or archive a separate registry file if the manifest should hash current bytes.

Useful? React with 👍 / 👎.

@munkyukim86 munkyukim86 merged commit cb20f2f into main Jun 17, 2026
12 checks passed
@munkyukim86 munkyukim86 deleted the fix/sync-repro-artifacts-v321 branch June 17, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant