feat: add experimental plant hosts#75
Conversation
…fia (eijex#24) Adds four new expression hosts selectable via --host: - arabidopsis (A. thaliana, NCBITaxon:3702) - tomato (S. lycopersicum, NCBITaxon:4081) - lemna (L. minor, NCBITaxon:4188) - wolffia (W. globosa, NCBITaxon:113308, pre-existing codon table wired up) Each host is status: experimental. Codon tables derived from Kazusa CodonUsage Database and NCBI RefSeq CDS annotations. Frequency values are normalized within each amino acid family (64 codons, sum=1.0). Changes: - data/: three new *_codons.json files (wolffia_globosa pre-existed) - cli/main.py: HOST_MAP + click.Choice extended with four new aliases - registry/current_parameter_registry.yaml: four host_profiles entries - schemas/design_package.schema.json: enum/oneOf extended for new IDs - tests/engines/profile/test_host_plants.py: parametrized coverage - CHANGELOG.md, docs/cli.md: updated accordingly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@KyungSeo116 is attempting to deploy a commit to the munkyukim86's projects Team on Vercel. A member of the Team first needs to authorize it. |
Code reviewFound 3 issues:
factorforge-cds/src/factorforge/cli/main.py Lines 19 to 27 in e8d1514
factorforge-cds/src/factorforge/registry/current_parameter_registry.yaml Lines 186 to 200 in e8d1514 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
|
Thanks for contributing this! Really appreciate you taking the time to add these plant hosts. Left a few notes above, once those are addressed, happy to get this merged. |
|
Thanks for the review! I'll work through the notes above and aim to have everything addressed by June 18 (KST). |
|
Can't wait, thanks! |
data/arabidopsis_thaliana_codons.jsondata/solanum_lycopersicum_codons.jsondata/lemna_minor_codons.jsoncli/main.pyHOST_MAP+click.Choice에 4종 추가current_parameter_registry.yamlhost_profiles등록 (status: experimental)design_package.schema.jsonhostProfileenum/oneOf 확장tests/engines/profile/test_host_plants.pyCHANGELOG.md/docs/cli.mdJSON 파일 품질 검증(64 코돈, 아미노산별 frequency 합계 ≈ 1.0, preferred 코돈 = 최고빈도 코돈)은 로컬에서 통과했으며, ruff lint/format도 clean 상태입니다.