add minor windows install notes to README.rst#6
Open
TheBigBear wants to merge 5 commits into
Open
Conversation
Author
|
@nicholasmhughes sorry for the markdown use of a table messing up the pre-commit rstcheck. Hope we are passed that now. |
Author
|
I hope that is it. @nicholasmhughes thanks for you patience. |
nicholasmhughes
requested changes
Jul 28, 2022
Comment on lines
+77
to
+89
| # Setup venv (linux & macos) | ||
| python3 -m venv .venv --prompt idemenv | ||
| source .venv/bin/activate | ||
| pip install -e . | ||
|
|
||
| # Setup venv (windows) | ||
| python3 -m venv .venv --prompt idemenv | ||
| . .venv\Scripts\activate | ||
| pip install -e . | ||
|
|
||
| # Note: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": | ||
| # https://visualstudio.microsoft.com/visual-cpp-build-tools/ | ||
|
|
Member
There was a problem hiding this comment.
This section has been a little problematic with rstcheck. How about something like the following?
Suggested change
| # Setup venv (linux & macos) | |
| python3 -m venv .venv --prompt idemenv | |
| source .venv/bin/activate | |
| pip install -e . | |
| # Setup venv (windows) | |
| python3 -m venv .venv --prompt idemenv | |
| . .venv\Scripts\activate | |
| pip install -e . | |
| # Note: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": | |
| # https://visualstudio.microsoft.com/visual-cpp-build-tools/ | |
| **Linux & MacOS:** | |
| .. code-block:: bash | |
| # Setup venv | |
| python3 -m venv .venv --prompt idemenv | |
| source .venv/bin/activate | |
| pip install -e . | |
| **Windows:** | |
| .. code-block:: | |
| # Setup venv | |
| python3 -m venv .venv --prompt idemenv | |
| . .venv\Scripts\activate | |
| pip install -e . | |
| .. note:: | |
| Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": | |
| https://visualstudio.microsoft.com/visual-cpp-build-tools/ | |
Author
|
absolutely, whatever works. I am so sorry, I do not have pre-commit, so I could not check it myself. same of course for the same entry on your saltenv git repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.