Add macOS Support & Home brew install#7
Open
Matars wants to merge 9 commits intoekrlstd:mainfrom
Open
Conversation
… file length and keep logic seperated
Author
|
some entries dont work as intended, like the duration and progress bar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding issue #3
Split
player_utils.pyintoplayer_utils_linux.py(Linux with playerctl) andplayer_utils_mac.py(macOS with AppleScript for Spotify/Music/iTunes)Automatically detect platform in init.py to import the appropriate module
Updated imports in main.py, fixed string formatting issues, and added safety checks to fix crashed on my machine