Conversation
Simplified config discovery which uses git and cwd boundaries only: - Remove project markers (Cargo.toml, package.json, go.mod, etc.) as boundaries - Keep only git repositories (.git) as meaningful boundaries for config search - Add current working directory as boundary for CLI mode - Update ConfigDiscovery struct to track current working directory - Maintain workspace root boundaries for LSP integration - Update README.md to reflect new simpler boundary detection strategy - Remove obsolete test for Cargo.toml boundary detection - Fix CLI integration test naming for consistency Fix the bug, when the violations printed with WARN severity instead of ERR: - The `print_cli_errors` function in `quickmark-cli` now directly uses the severity from the `RuleViolation` struct, instead of looking it up from the configuration. This simplifies the code and makes it more robust. - The `MultiRuleLinter` in `quickmark-core` now injects the correct severity into each `RuleViolation` as it is created. - The test for `print_cli_errors` has been updated to reflect these changes and now uses the `MultiRuleLinter` to generate violations with the correct severities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified config discovery which uses git and cwd boundaries only:
Fix the bug, when the violations printed with WARN severity instead of ERR:
print_cli_errorsfunction inquickmark-clinow directly uses the severity from theRuleViolationstruct, instead of looking it up from the configuration. This simplifies the code and makes it more robust.MultiRuleLinterinquickmark-corenow injects the correct severity into eachRuleViolationas it is created.print_cli_errorshas been updated to reflect these changes and now uses theMultiRuleLinterto generate violations with the correct severities. 🤖 Generated with Claude Code