Skip to content

Rename attribute #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theletterf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename attribute #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/reference/edot-php/migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Switch from `php.ini`-based configuration to environment variables. The followin
| `elastic_apm.service_name = my-app` | `OTEL_SERVICE_NAME=my-app` | Defines the logical service name |
| `elastic_apm.server_url = http://...` | `OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4318` | Sets OTLP exporter endpoint |
| `elastic_apm.secret_token = token123` | `OTEL_EXPORTER_OTLP_HEADERS="Authorization=Bearer token123"` | Sets auth header for OTLP exporter |
| `elastic_apm.environment = production` | `OTEL_RESOURCE_ATTRIBUTES=deployment.environment=production` | Adds environment context to exported data |
| `elastic_apm.environment = production` | `OTEL_RESOURCE_ATTRIBUTES=deployment.environment.name=production` | Adds environment context to exported data |

::::{tip}
EDOT PHP does not require changes to your code or Composer configuration — instrumentation works automatically after package installation.
Expand Down Expand Up @@ -140,7 +140,7 @@ The following are Elastic APM PHP agent settings that you can migrate to EDOT PH
| `disable_instrumentations` | [`OTEL_PHP_DISABLED_INSTRUMENTATIONS`](https://opentelemetry.io/docs/languages/php/sdk/#configuration) | Comma-separated list of instrumentations to disable. |
| `disable_send` | Not available | No direct option. Could potentially be simulated with custom exporters or filtering processors. |
| `enabled` | [`ELASTIC_OTEL_ENABLED`](/reference/edot-php/configuration.md#general-configuration) | Enables or disables EDOT PHP instrumentation entirely. |
| `environment` | [`OTEL_RESOURCE_ATTRIBUTES`](https://opentelemetry.io/docs/languages/sdk-configuration/general/#otel_resource_attributes) | Add deployment metadata (e.g., `deployment.environment=prod`). |
| `environment` | [`OTEL_RESOURCE_ATTRIBUTES`](https://opentelemetry.io/docs/languages/sdk-configuration/general/#otel_resource_attributes) | Add deployment metadata (e.g., `deployment.environment.name=prod`). |
| `global_labels` | [`OTEL_RESOURCE_ATTRIBUTES`](https://opentelemetry.io/docs/languages/sdk-configuration/general/#otel_resource_attributes) | Set global key-value pairs for all spans/metrics. |
| `log_level` | [`OTEL_LOG_LEVEL`](https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/#general-sdk-configuration), [`ELASTIC_OTEL_LOG_LEVEL_FILE`](/reference/edot-php/configuration.md#logging-configuration) | Controls log verbosity globally (`OTEL_LOG_LEVEL`) or per sink (e.g., file, stderr, syslog via `ELASTIC_OTEL_LOG_LEVEL_*`). |
| `server_url` | [`OTEL_EXPORTER_OTLP_ENDPOINT`](https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#otel_exporter_otlp_endpoint) | Sets OTLP exporter endpoint. Defaults to `http://localhost:4318`. |
Expand Down
2 changes: 1 addition & 1 deletion prod/native/libsemconv/include/opentelemetry/semconv/deployment_attributes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ namespace deployment
*/
OPENTELEMETRY_DEPRECATED
static constexpr const char *kDeploymentEnvironment
= "deployment.environment";
= "deployment.environment.name";

/**
* Name of the <a href="https://wikipedia.org/wiki/Deployment_environment">deployment environment</a> (aka deployment tier).
Expand Down
Loading