Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| for c in self.choice_set.all(): | ||
| v += c.votes | ||
| return v | ||
| return sum(c.votes for c in self.choice_set.all()) |
There was a problem hiding this comment.
Function Poll.total_votes refactored with the following changes:
- Convert for loop into call to sum() (
sum-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
| if self.poll.ballots == 0: | ||
| return 0 | ||
| return self.votes*100/self.poll.ballots | ||
| return 0 if self.poll.ballots == 0 else self.votes*100/self.poll.ballots |
There was a problem hiding this comment.
Function Choice.percentage refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| try: | ||
| request.POST['choice'+str(counter+1)] | ||
| except (KeyError): | ||
| pass | ||
| else: | ||
| choice.votes += 1 | ||
| choice.save() | ||
| try: | ||
| request.POST[f'choice{str(counter + 1)}'] | ||
| except (KeyError): | ||
| pass | ||
| else: | ||
| choice.votes += 1 | ||
| choice.save() |
There was a problem hiding this comment.
Function vote refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 1.17%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!