test: guard OpenClaw plugin install metadata contracts#95
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds two validation tests to the Eva Brain install contract suite. The first test verifies that Install Contract Tests
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Reality-sync triage: still useful, not stale. This is a narrow test-only guard for plugin/install version contracts and the missing ./bin/gbrain regression class. It is non-blocking for the dashboard/runtime-shell work, but I would keep it open and refresh/merge when we next touch Eva Brain packaging so #93/#94 stay guarded by tests instead of tribal memory. |
TL;DR
Eva found two packaging-contract footguns that are mostly fixed on current
master, but not yet protected well enough: the root OpenClaw bundle must launch the installedgbrain serveruntime, and repo-owned version surfaces must agree. This PR adds focused install-contract tests so the repo cannot drift back to a missing./bin/gbrainmanifest or mismatched package/plugin versions.Closes #93.
Closes #94.
Why
Agents and installers need one boring answer to two questions:
If those answers drift, a fresh checkout can look installable while pointing at a missing binary, or a healthy install can look stale because package metadata, plugin metadata, and runtime output disagree.
What Changed
command: "gbrain"args: ["serve"]package.json:openclaw.plugin.jsonplugins/gbrain-codex/package.jsonplugins/gbrain-codex/.codex-plugin/plugin.jsonsrc/version.tsderiving runtime CLI version from package metadataNotes
The current
mastercheckout already has the direct symptoms fixed: rootopenclaw.plugin.jsonis at0.33.0and usesgbrain serve, not./bin/gbrain. This PR makes that an explicit contract instead of relying on humans to notice future drift.Validation
git diff --check bun test test/install-contract.test.tsSummary by CodeRabbit