Skip to content

Support Cython 3.0#2

Open
orbisvicis wants to merge 1 commit into
elijahr:masterfrom
orbisvicis:cython-3.0
Open

Support Cython 3.0#2
orbisvicis wants to merge 1 commit into
elijahr:masterfrom
orbisvicis:cython-3.0

Conversation

@orbisvicis

Copy link
Copy Markdown

Fixes errors and warnings when building against Cython 3.0, except the deprecation of "IF". Of special attention, I reverted the workaround for "INT32_MIN" and "INT64_MIN" in "src/aiolo/pack.pyx". I believe the original issue was due to a typo in the "libc.stdint" imports.

@orbisvicis

orbisvicis commented Jul 26, 2023

Copy link
Copy Markdown
Author

I also added exception handling to three functions in src/aiolo/lo.pxd, to match the new Cython defaults but also because I think exceptions may be raised in sections running with the GIL - might want to confirm that.

Fixes errors and warnings when building against Cython 3.0, except the
deprecation of "IF". Of special attention, I reverted the workaround for
"INT32_MIN" and "INT64_MIN" in "src/aiolo/pack.pyx". I believe the
original issue was due to a typo in the "libc.stdint" imports.
@orbisvicis

Copy link
Copy Markdown
Author

This is blocked by this Cython 3.x bug: cython/cython#5240.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant