[codex] Extract client list runtime wiring#1048
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR moves client-list browser globals behind a small runtime adapter. The main changes are:
Confidence Score: 5/5This looks safe to merge. No blocking issues found in the changed code. No files need attention.
What T-Rex did
Important Files Changed
Reviews (2): Last reviewed commit: "Extract client list runtime wiring" | Re-trigger Greptile |
5cecc29 to
f6974ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js/client-list-runtime.jsto isolate client-list browser global hooks behind named runtime adapters.js/client-list.jsapp-shell globals through the adapter and remove directwindow./window[...]references from the module.567to547window references.Validation
node tests/test-client-list-runtime.jsnode tests/test-client-list-delegated-actions.jsnode tests/verify-modules.jsnpm run qualitynpm run typechecknpm run typecheck:checkjsnpx vitest run tests/client-list-runtime.test.jsnpm testnpx playwright test tests/playwright/client-list-browser-coverage.spec.js --workers=1./run-tests.sh