Skip to content

[codex] Extract client list runtime wiring#1048

Merged
elkimek merged 1 commit into
mainfrom
codex/extract-client-list-runtime-wiring
Jul 5, 2026
Merged

[codex] Extract client list runtime wiring#1048
elkimek merged 1 commit into
mainfrom
codex/extract-client-list-runtime-wiring

Conversation

@elkimek

@elkimek elkimek commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add js/client-list-runtime.js to isolate client-list browser global hooks behind named runtime adapters.
  • Route js/client-list.js app-shell globals through the adapter and remove direct window. / window[...] references from the module.
  • Add adapter/static regression coverage and tighten the quality baseline from 567 to 547 window references.
  • Update service-worker cache, module verifier, typecheck includes, and app version for cache invalidation.

Validation

  • node tests/test-client-list-runtime.js
  • node tests/test-client-list-delegated-actions.js
  • node tests/verify-modules.js
  • npm run quality
  • npm run typecheck
  • npm run typecheck:checkjs
  • npx vitest run tests/client-list-runtime.test.js
  • npm test
  • npx playwright test tests/playwright/client-list-browser-coverage.spec.js --workers=1
  • ./run-tests.sh

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
get-based Error Error Jul 5, 2026 12:43pm

@greptile-apps

greptile-apps Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR moves client-list browser globals behind a small runtime adapter. The main changes are:

  • New js/client-list-runtime.js adapter for app-shell hooks.
  • js/client-list.js routes global calls through named adapter functions.
  • Latitude AI refinement now rechecks provider availability inside the debounce.
  • Service-worker, module verification, typecheck, and tests include the new module.
  • App version and quality baseline were updated.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

No files need attention.

T-Rex T-Rex Logs

What T-Rex did

  • Validated the browser runtime adapter by comparing the before and after states; the after state shows all runtime tests passing and zero direct window references, confirming the adapter presence and imports work as expected.
  • Compared the quality-cache probes, with a base before state and a head after state that includes full command outputs and grep anchors for service-worker.js:183 and version.js:5.
  • Executed the client-list browser flow and verified that the head state preserves the reachable user-visible contract while updating haplogroup, refreshing the profile button, and emitting a save notification.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
js/client-list-runtime.js Adds runtime wrappers for client-list browser globals.
js/client-list.js Delegates client-list global hooks through the new adapter and updates latitude provider timing.
service-worker.js Adds the new runtime module to the app-shell cache list.
tests/test-client-list-runtime.js Adds adapter coverage for runtime hooks and missing-hook behavior.
tests/test-client-list-delegated-actions.js Adds checks for adapter routing and latitude debounce rechecking.

Reviews (2): Last reviewed commit: "Extract client list runtime wiring" | Re-trigger Greptile

Comment thread js/client-list.js
@elkimek elkimek force-pushed the codex/extract-client-list-runtime-wiring branch from 5cecc29 to f6974ca Compare July 5, 2026 12:43
@elkimek elkimek merged commit 9e9106a into main Jul 5, 2026
5 of 6 checks passed
@elkimek elkimek deleted the codex/extract-client-list-runtime-wiring branch July 5, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant