feat: improve language detection with multi-sampling#7
Open
Zonrotan wants to merge 2 commits into
Open
Conversation
Changed wording for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new auto-detect works great, but has a hidden flaw: when
language=None, Whisper natively limits its language detection to the first 30 seconds of the audio.If a video starts with silent logos, long musical intros, or background noise, Whisper often hallucinates a random language (e.g., guessing Thai for a Swedish video). Because Whisper locks in its first guess for the entire file, this ruins the transcription and triggers unnecessary translation logic.
Solution
This PR bypasses Whisper's 30-second limitation with a lightweight
detect_robust_languagehelper function that samples three snippets from the file. Instead of trusting just the first 30 seconds, it:model.transcribe()on them.Why this approach?
Since the
audiois already loaded as a numpy array, slicing it and running inference on these snippets takes only a fraction of a second and requires no external dependencies (likeffmpeg).Changes Made
detect_robust_languageinwhisper.pymodel.transcribecall (when no metadata is present).Sounds good, no? 😃