Decode encoded strings in entry titles. Fixes skeeto/elfeed#484#564
Open
Thaodan wants to merge 1 commit into
Open
Decode encoded strings in entry titles. Fixes skeeto/elfeed#484#564Thaodan wants to merge 1 commit into
Thaodan wants to merge 1 commit into
Conversation
Collaborator
|
I see that there is an encoding issue, but it looks as if the fix is at the wrong place. Shouldn't we decode the titles earlier? |
Contributor
Author
|
Daniel Mendler ***@***.***> writes:
I see that there is an encoding issue, but it looks as if the fix is
at the wrong place. Shouldn't we decode the titles earlier?
Where do you think should the change go?
|
Collaborator
|
No idea yet. But it does not look right to replicate the decoding at multiple places. Maybe it should happen when adding entries to the database. |
Contributor
Author
Hm I that. Depends on how the data should be saved, decoded or encoded. |
Thaodan
force-pushed
the
decode_encoded_strings
branch
2 times, most recently
from
45afbf4 to
ca4e7a6
Compare
Thaodan
force-pushed
the
decode_encoded_strings
branch
from
ca4e7a6 to
1c24605
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #531 and #540.
Feel free to merge in any order.