Skip to content

Conversation

@daniel-stoian-lgp
Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp commented Feb 2, 2026

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

query-string package changes:
7.x Structure

  • Single file architecture: Everything lived in index.js
  • No internal imports: All code was self-contained in one module

8.x Structure

  • Split file architecture: Code refactored into multiple internal files
  • Main file (index.js) now acts as a re-exporter:

After updating query-string in ui-test-utils:

Before the Fix
What happened during build:

  • enact/dev-utils/EnactFrameworkRefPlugin detected the internal import ./base.js
  • Plugin externalized it as: @enact/ui-test-utils/node_modules/query-string/base
  • View bundle contained a reference expecting the framework to provide this module
  • View tries to require: enact_framework('@enact/ui-test-utils/node_modules/query-string/base')
  • Framework provides: 'query-string' (only the main export)
  • Error: Cannot find module '@enact/ui-test-utils/node_modules/query-string/base' in the view of the screenshot tests [Theme]-View app

Resolution

Fixed EnactFrameworkRefPlugin to detect imports that come from ignored packages and bundle them directly into the view instead of trying to externalize them.

After the Fix
What happens during build:

  • Plugin detects import originates from ignored package (@enact/ui-test-utils)
  • Instead of externalizing, bundles query-string (including base.js) directly into the view "/* harmony import / var base_js__WEBPACK_IMPORTED_MODULE_0_ = webpack_require(/! ./base.js */ "./node_modules/@enact/ui-test-utils/node_modules/query-string/base.js")"
  • query-string is self-contained in the view bundle

Additional Considerations

Links

NXT-9086

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

…red packages and bundle them directly into the view instead of trying to externalize them.
@daniel-stoian-lgp daniel-stoian-lgp changed the title NXT-9086 NXT-9086: Added a check to blundle sub-dependencies of ignored packages Feb 3, 2026
@daniel-stoian-lgp daniel-stoian-lgp changed the title NXT-9086: Added a check to blundle sub-dependencies of ignored packages NXT-9086: Added a check to no externalize sub-dependencies of ignored packages Feb 3, 2026
@daniel-stoian-lgp daniel-stoian-lgp changed the title NXT-9086: Added a check to no externalize sub-dependencies of ignored packages NXT-9086: Added a check to not externalize sub-dependencies of ignored packages Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants