Conversation
|
Thanks for this Martin! I'm not exactly sure what you mean by skipping HTML tags, could you give an example? Additionally, is this part of common markdown or not? Note: it may take a while to review PRs at the moment as I'm extremely busy for a few weeks. Additionally I think I need to create a simple example and test suite before extending Imgui_Markdown too much, as the intention is to be both lightweight and fast. I think this contribution will likely meet those criteria but I will also need to check if this is widely useful. |
|
it's not part of the markdown standard - but as md files are often used to generate html pages - either on github or mkdocs... I have e.g. this in my markdown to embed a youtube video https://github.com/vengi-voxel/vengi/blob/master/docs/voxedit/Index.md ( https://vengi-voxel.github.io/vengi/voxedit/Index/ <--- here the html mkdocs output) no problem, take your time. To be honest I am not sure if it should be part of the upstream project because I don't know if it's of use for anyone else. I am just using this markdown for mkdocs and also for imgui as offline help, thus in my usecase, i don't want html to be visible. |
|
Thanks, I understand now. This does seem a bit unusual, indeed I wonder if a script to go alongside imgui_markdown might be a better approach longterm. Another idea might be to allow processing functions or extensions to be used similar to the format callback so you don't need to fork the code but can just add a callback. For now let's keep this PR open whilst we think about it. |
(not sure if this is wanted upstream)
some docs contain html tags (like my youtube embeddings of videos for the mkdocs markdown) - this option allows the user to remove the tags via flag