Fix entire cli hanging on prepare-commit-msg git hook#561
Open
sbalay wants to merge 1 commit intoentireio:mainfrom
Open
Fix entire cli hanging on prepare-commit-msg git hook#561sbalay wants to merge 1 commit intoentireio:mainfrom
prepare-commit-msg git hook#561sbalay wants to merge 1 commit intoentireio:mainfrom
Conversation
Replace go-git's worktree.Status() with `git diff --cached --name-only` in getStagedFiles(). worktree.Status() scans the entire working tree (O(all files)), which hangs on large repos with deep node_modules. The native git command only lists staged files (O(staged files)) and completes in under a second. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reported this in Discord earlier. After setting up the entire cli in my project, I wasnt able to commit anymore.
git commitwould just hang.After some quick research, I found that the root cause for the hang was the entire cli hook:
entire hooks git prepare-commit-msg, it just hangs.Proposed solution
Disclaimer: This solution was written by claude code. I think it makes sense, that's why I'm sending this PR but my knowledge around how the entire cli works is limited
The codebase already uses exec.CommandContext(ctx, "git", ...) extensively, so this fix reuses and existing pattern, it is not creating a new one:
Test plan