fix(a11y): label icon-only controls#114
Open
Yurii214 wants to merge 1 commit into
Open
Conversation
Add explicit accessible names to tooltip-only icon controls so assistive tech announces their purpose without relying on visual tooltips. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-labels to tooltip-only icon controls so screen readers announce their purpose.Switch to dark mode/Switch to light mode).Fixes #30
Test plan
npm run lintnpm run buildIconButtoninstances insrc/**/*.tsxnow have anaria-label.Notes
No before/after media is attached because this change only adds accessibility metadata; it does not alter rendered layout, styling, or visible UI.
Made with Cursor