fix(bounties): restore pagination on IssuesList#1028
Open
blinkeye-lcm wants to merge 5 commits into
Open
Conversation
Contributor
|
|
anderdc
requested changes
May 11, 2026
Collaborator
anderdc
left a comment
There was a problem hiding this comment.
Please scope this down to what #1027 asks for.
Keep:
- Pagination state in
IssuesList.tsxwith the set-state-during-render reset on filter/search/sort/view/pageSize change. - Promotion of
TablePaginationfromsrc/components/miners/tosrc/components/common/and updated imports in the three existing callers. - Rows-per-page
<Select>using the existingISSUES_CARD_ROWS/ISSUES_LIST_ROWSconstants.
Drop:
- The new
getDisplayRepositoryName()helper insrc/utils/issueStatus.tsand allissue.repositoryFullName→getDisplayRepositoryName(issue.repositoryFullName)swaps inBountyCard.tsxandIssuesList.tsx(search filter, sort key, chart aggregation, repository column). #1027 doesn't ask for an unknown-repository fallback. - The toolbar rendering change that makes
inlineToolbarrender unconditionally and treats the sidebar portal as additive. Keep the existingusePortal ? <Portal> : inlineToolbarsplit.
This was referenced May 11, 2026
Contributor
Author
|
Hi @anderdc |
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #983 removed the page state and
<TablePagination>block fromIssuesListwithout a replacement, so every bounty in the merged active/registered/history feed renders into the DOM on first paint. Restores client-side pagination using the existingISSUES_DEFAULT_LIST_ROWSandISSUES_DEFAULT_CARD_ROWSconstants and the sharedTablePaginationcomponent. Two small cleanups drop out of the same diff:TablePaginationfromsrc/components/miners/tosrc/components/common/. The component contains no miner-specific code, and four components across two domains import it after this change:MinerPRsTable,MinerRepositoriesTable,MinerOpenDiscoveryIssuesByRepo, andIssuesList. The new home matches where every other shared table primitive lives. The move usesgit mvso blame stays intact.useEffectwhen filter, search, sort, or view changes. The stale, clamped page never gets committed, so a one-frame flash never reaches the user on filter switches.Files touched:
src/components/issues/IssuesList.tsx(pagination restored, page reset, import path)src/components/common/TablePagination.tsx(moved fromsrc/components/miners/)src/components/miners/MinerPRsTable.tsx(import path only)src/components/miners/MinerRepositoriesTable.tsx(import path only)src/components/miners/MinerOpenDiscoveryIssuesByRepo.tsx(import path only)Related Issues
Closes #1027
Type of Change
Screenshots
Before
/bountiesfirst paint materializes everyBountyCard(card view) or<TableRow>(list view) at once. Multi-second layout work and jerky scroll on a feed with a few hundred completed bounties.After
First paint shows the first 12 cards in card view or 10 rows in list view, with prev/next controls below. Filter, search, sort, and view-mode changes return to page 0 without a visible flash.
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses