feat(watchlist): add per-source filter chips to Pull Requests tab#1072
Open
Khaostica wants to merge 1 commit into
Open
feat(watchlist): add per-source filter chips to Pull Requests tab#1072Khaostica wants to merge 1 commit into
Khaostica wants to merge 1 commit into
Conversation
Contributor
|
Skipping in this review pass — no CI checks reported yet (workflow waiting for maintainer approval). Will revisit once CI runs. |
Adds three multi-select chips — Starred / Miner / Repo — to the Watchlist > Pull Requests tab toolbar, matching the colors and labels of the existing source badges (entrius#789, entrius#799). All three are selected by default, preserving the auto-show behavior from entrius#789. Toggling chips narrows the list to PRs whose source set intersects the active selection. Selection is persisted to localStorage under gittensor.watchlist.prs-source-filter.v1 (JSON-serialized array of WatchedPRSource values, with all-on as the empty-storage fallback). Cross-tab sync via the storage event mirrors useWatchlist.ts. Closes entrius#969.
Khaostica
force-pushed
the
feat/watchlist-pr-scope-filter
branch
from
0be9a38 to
5ec40e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three multi-select chips (Starred/Miner/Repo) to the Watchlist->Pull Requests tab toolbar, matching the colors and labels of the existing source badges (#789, #799). All three are selected by default, preserving the auto-show behavior from #789. Toggling chips on makes PRs with the chip's label visible, and PRs are only invisible if 0/3 of the chips with their label are toggled on (union-based).
Selection is persisted to localStorage under
gittensor.watchlist.prs-source-filter.v1 (JSON-serialized array of WatchedPRSource values, with all-on as the empty-storage fallback). Cross-tab sync via the storage event mirrors useWatchlist.ts.
Related Issues
Closes #969.
Type of Change
Screenshots
Before:
After:
Video
Note: The coloring is inaccurate in the recording, reference the above images for accurate coloring.
https://github.com/user-attachments/assets/94da9135-aad0-4a8e-85d7-484faf4cd94b
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses