Update lab manual: meetings, values and openness#109
Conversation
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
seabbs
left a comment
There was a problem hiding this comment.
Looks good. Some minor points - perhaps better addressed as their own issues/discussion items.
|
Do we want to add something around expectations with code review in the group. Not so much if it happens but when it is being done expectations around it. i.e be nice, constructive, don't ask people to review LLM generated code you haven't reviewed etc etc Could be its own issue |
|
Maybe this is an issue but there is a statement in the aims that we are value and aim to develop software. There is then nothing in the output about valuing software alongside traditional academic goods (i.e there is just a publications section). I also couldn't see anything about code for a paper being as much a product of the paper as the manuscript and expectations around that. Also nothing about trying to expand/adapt existing software when doing new work vs rolling new models from scratch that I can see. |
|
On a related point there is nothing about contributing to lab software and how that works/expectations etc. |
|
And a related related point nothing about maintaince of those tools, ownership, decision making etc. |
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
…cussion Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
|
Re code review expectations: added "Review your own code before asking others to review it" to the Code section. See b444b92. |
|
Re software valued alongside publications: now in Group principles — "We value software and tools as research outputs alongside papers". See 9f5c070. |
|
Re contributing to lab software: covered in new Projects section — "build on each other's work... extend existing tools rather than starting from scratch". See 49da324. |
|
Re maintenance, ownership and decision making: "Group packages have a named maintainer who is responsible for technical decisions about design, API and releases." See 49da324. |
seabbs
left a comment
There was a problem hiding this comment.
Nice this looks good to me.
Summary