Fixes #1107: Remove deprecation wrappers for forecast_sample_multivariate#1129
Open
nikosbosse wants to merge 1 commit intomainfrom
Open
Fixes #1107: Remove deprecation wrappers for forecast_sample_multivariate#1129nikosbosse wants to merge 1 commit intomainfrom
nikosbosse wants to merge 1 commit intomainfrom
Conversation
…iate Since multivariate scoring hasn't been in a CRAN release yet, the deprecation wrappers added in #1072 are not needed for backwards compatibility. This removes: - The deprecated class name "forecast_sample_multivariate" from the class vector (it was appended after "forecast" for compat) - assert_forecast.forecast_sample_multivariate S3 method alias - is_forecast_sample_multivariate() deprecated function - score.forecast_sample_multivariate S3 method alias - get_metrics.forecast_sample_multivariate S3 method alias Also regenerates example data and documentation to reflect the clean class vector. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
- Coverage 97.96% 97.95% -0.01%
==========================================
Files 37 37
Lines 1961 1955 -6
==========================================
- Hits 1921 1915 -6
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAUDE:
Summary
forecast_sample_multivariateclass name from the class vector (was appended afterforecastfor backwards compatibility)assert_forecast.forecast_sample_multivariateS3 method aliasis_forecast_sample_multivariate()deprecated functionscore.forecast_sample_multivariateS3 method aliasget_metrics.forecast_sample_multivariateS3 method aliasSince multivariate scoring hasn't been in a CRAN release yet (merged after v2.1.2), these deprecation wrappers from #1072 aren't needed for backwards compatibility.
Test plan
NaNs producedin transform-forecasts) is unrelatedCloses #1107
🤖 Generated with Claude Code