Fix assert_forecast_type actual parameter for multivariate sample#1130
Open
nikosbosse wants to merge 1 commit intomainfrom
Open
Fix assert_forecast_type actual parameter for multivariate sample#1130nikosbosse wants to merge 1 commit intomainfrom
nikosbosse wants to merge 1 commit intomainfrom
Conversation
assert_forecast.forecast_multivariate_sample was passing the full class name "forecast_multivariate_sample" as the actual parameter to assert_forecast_type(), instead of just "multivariate_sample" (the type name with the "forecast_" prefix stripped). All other forecast types pass the short name (e.g. "sample", "quantile", "binary"). This caused assert_forecast(data, forecast_type = "multivariate_sample") to error even though "multivariate_sample" is the correct type string returned by get_forecast_type(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 37 37
Lines 1961 1961
=======================================
Hits 1921 1921
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert_forecast.forecast_multivariate_samplepassing"forecast_multivariate_sample"(the full class name) instead of"multivariate_sample"(the short type name) toassert_forecast_type(actual = ...)"sample","quantile","binary","multivariate_point"), so this was an inconsistency introduced in Fix #1071: Rename forecast_sample_multivariate class to match constructor #1072Bug:
assert_forecast(data, forecast_type = "multivariate_sample")would error with:even though
"multivariate_sample"is the correct type string returned byget_forecast_type().Test plan
assert_forecast(data, forecast_type = "multivariate_sample")— fails before fix, passes after🤖 Generated with Claude Code