Skip to content

Fix: Improve Tiers Display Format #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulofph merged 4 commits into from
Apr 23, 2026
Merged

Fix: Improve Tiers Display Format #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1514c97
Fix: Improve Tiers Display Format
paulofph Apr 23, 2026
7ac9004
Remove unecessary for the current iteration
paulofph Apr 23, 2026
7b54376
Revert averageWithPrecision from compute-cumulative-value
paulofph Apr 23, 2026
eaa6cb3
Add changeset
paulofph Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/flat-moments-flash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@epilot/pricing': patch
---

Improve tier display string
10 changes: 5 additions & 5 deletions src/tiers/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ describe('getTierDescription', () => {
${PricingModel.tieredVolume} | ${tierWithUnitAmount} | ${'kWh'} | ${'de'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${false} | ${undefined} | ${undefined} | ${'Starts at 10,00 €/kWh'}
${PricingModel.tieredVolume} | ${tierWithUnitAmount} | ${'kWh'} | ${'en'} | ${'USD'} | ${mockedTranslationFn} | ${true} | ${false} | ${undefined} | ${undefined} | ${'Starts at $10.00/kWh'}
${PricingModel.tieredVolume} | ${tierWithUnitAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${true} | ${undefined} | ${undefined} | ${'Starts at €10.00/kWh'}
${PricingModel.tieredVolume} | ${tierWithSubunitAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${true} | ${undefined} | ${undefined} | ${'Starts at 5.12 cents/kWh'}
${PricingModel.tieredVolume} | ${tierWithSubunitAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${true} | ${undefined} | ${undefined} | ${'Starts at 5.123412 cents/kWh'}
${PricingModel.tieredVolume} | ${tierWithSubunitAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${true} | ${undefined} | ${4} | ${'Starts at 5.1234 cents/kWh'}
${PricingModel.tieredVolume} | ${tierWithUnitAmount} | ${undefined} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${false} | ${undefined} | ${undefined} | ${'Starts at €10.00'}
${PricingModel.tieredVolume} | ${tierWithUnitAmount} | ${'unit'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${false} | ${undefined} | ${undefined} | ${'Starts at €10.00'}
Expand Down Expand Up @@ -261,10 +261,10 @@ describe('getTierDescription', () => {

it.each`
pricingModel | tier | unit | locale | currency | t | showStartsAt | enableSubunitDisplay | shouldDisplayOnRequest | tax | expected
${PricingModel.tieredGraduated} | ${tierWithUnitAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${false} | ${undefined} | ${{ isInclusive: true, rate: 10 }} | ${'Starts at €9.09/kWh'}
${PricingModel.tieredVolume} | ${tierWithUnitAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${false} | ${undefined} | ${{ isInclusive: true, rate: 10 }} | ${'Starts at €9.09/kWh'}
${PricingModel.tieredVolume} | ${tierWithSubunitAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${true} | ${undefined} | ${{ isInclusive: true, rate: 10 }} | ${'Starts at 4.66 cents/kWh'}
${PricingModel.tieredFlatFee} | ${tierWithFlatFeeAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${false} | ${undefined} | ${{ isInclusive: true, rate: 10 }} | ${'Starts at €9.09'}
${PricingModel.tieredGraduated} | ${tierWithUnitAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${false} | ${undefined} | ${{ isInclusive: true, rate: 10 }} | ${'Starts at €9.090909090909/kWh'}
${PricingModel.tieredVolume} | ${tierWithUnitAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${false} | ${undefined} | ${{ isInclusive: true, rate: 10 }} | ${'Starts at €9.090909090909/kWh'}
${PricingModel.tieredVolume} | ${tierWithSubunitAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${true} | ${undefined} | ${{ isInclusive: true, rate: 10 }} | ${'Starts at 4.657647 cents/kWh'}
${PricingModel.tieredFlatFee} | ${tierWithFlatFeeAmount} | ${'kWh'} | ${'en'} | ${'EUR'} | ${mockedTranslationFn} | ${true} | ${false} | ${undefined} | ${{ isInclusive: true, rate: 10 }} | ${'Starts at €9.090909090909'}
`(
'should return correct net values for the tier, when pricingModel=$pricingModel, unit=$unit, locale=$locale, currency=$currency, showStartsAt=$showStartsAt',
({
Expand Down
4 changes: 2 additions & 2 deletions src/tiers/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export function getTierDescription(
return;
}

const { showStartsAt = true, enableSubunitDisplay = false, precision = 2 } = options;
const { showStartsAt = true, enableSubunitDisplay = false, precision } = options;
const showUnitAmount =
(pricingModel === PricingModel.tieredGraduated || pricingModel === PricingModel.tieredVolume) &&
typeof tier.unit_amount === 'number';
Expand All @@ -161,7 +161,7 @@ export function getTierDescription(
currency,
locale,
enableSubunitDisplay,
precision,
...(precision !== undefined ? { precision } : { useRealPrecision: true }),
};

const unitAmountDecimal =
Expand Down
Loading