chore(design-client): type parseThemeFromDesign response#387
Open
serge-sedelnikov wants to merge 3 commits into
Open
chore(design-client): type parseThemeFromDesign response#387serge-sedelnikov wants to merge 3 commits into
serge-sedelnikov wants to merge 3 commits into
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
…y-config-to-use-lambda-invoke-with-internal-auth-tokens
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@epilot/design-clientto0.5.4type: objectresponse of theparseThemeFromDesignendpoint with a newParseThemeFromDesignRespschematheme(Theme) anddesign(ItemMetada + DesignItem + Custom_Style + Journey) so consumers get strong typing for the parsed resultNotes
ER-4987/entity-client, but the actual diff is scoped todesign-clientonly. Happy to rename / amend if reviewers prefer.Test Plan
clients/design-client/src/openapi.d.tsregenerates cleanly from the updatedopenapi.jsonparseThemeFromDesignpick up the typedParseThemeFromDesignRespinstead ofany/object