Replace USD with CURRENCY_CODE in rp2_full_report.py#144
Open
archont00 wants to merge 2 commits into
Open
Conversation
The sheet Summary of the full report had "USD" currency code hard-coded in the headings. Replacing with reference to CURRENCY_CODE instead.
Collaborator
|
Sorry about the delay, can you update the tests as well? I think you just need to update the golden files to reflect the change perhaps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sheet Summary of the full report had "USD" currency code hard-coded in the headings. Replacing with reference to CURRENCY_CODE instead. Tested with rp2_generic plugin.