fixed and refactored set_show_item -> display_item#1036
Draft
stm2 wants to merge 28 commits intoeressea:developfrom
Draft
fixed and refactored set_show_item -> display_item#1036stm2 wants to merge 28 commits intoeressea:developfrom
stm2 wants to merge 28 commits intoeressea:developfrom
Conversation
fix resistance tests
fix null-pointer crash
some mild refactoring, but no real changes.
https://bugs.eressea.de/view.php?id=2980 Ausserdem: Flammenschwerter vor Laenschwertern bevorzugen.
Co-authored-by: Enno Rehling <enno@eressea.de>
Co-authored-by: Enno Rehling <enno@eressea.de>
Sehr schön, sogar mit Tests!
* narrow down failing test' * on failure, print the filename
let install script use cmake --install
this resolves issue eressea#1026
Co-authored-by: Enno Rehling <enno@eressea.de>
* upgrade to python3 * get rid of python2 compatibility --------- Co-authored-by: Enno Rehling <enno@eressea.de>
ennorehling
reviewed
Oct 3, 2023
Member
ennorehling
left a comment
ennorehling
left a comment
There was a problem hiding this comment.
Im großen und ganzen in Ordnung, denke ich. Eine stylistische Anmerkung hatte ich.
| { | ||
| int age, flag = 0; | ||
| char ch; | ||
| char potions_shown; |
Member
There was a problem hiding this comment.
Warum ist das hier kein int? Der natürliche Typ für Zahlen ist int, char für Zeichen. Wir müssen hier keine Bytes auf dem Stack sparen, die sind wahrscheinlich sowieso 32-bit aligned. Ein char zu benutzen führt nur dazu, dass in der Signatur von report_item ein char * steht, was normal einen Buffer für einen String signalisiert, es macht also das Lesen des Codes notwendig, um zu verstehen, was dort als Parameter erwartet wird.
ennorehling
requested changes
Oct 9, 2023
Member
ennorehling
left a comment
ennorehling
left a comment
There was a problem hiding this comment.
Den Kommentar mit char potions_shown bitte kurz ändern, dann akzeptiere ich den PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server tried to display starting items like ROI as potions and failed. Moved the display_item/potion/race stuff to reports.c