feat: use delta f formulation for implicit solve and improve Kernel-based collision operator energy conservation#254
Open
jpbrodrick89 wants to merge 3 commits intojpb/dependency-injection2from
Open
Conversation
…ased collision operator energy conservation
jpbrodrick89
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another stacked PR, this one on #245 . Small impact on vlasov1d should be a net improvement.
Note the LogMeanFlux scheme allows energy conservation in the limit of small timestep without performing iterations at the cost of no formal guarantee on positivity (in practice I've not seen this violated)