feat: correlation IDs, error reporting and trade audit visibility (#81)#103
Open
zeemscript wants to merge 1 commit into
Open
feat: correlation IDs, error reporting and trade audit visibility (#81)#103zeemscript wants to merge 1 commit into
zeemscript wants to merge 1 commit into
Conversation
|
@zeemscript Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #81
x-request-idper request (honors client-sent IDs), echo in response header, and bind to Pino logger so every log line includesrequest_idrequest_idand shortsupport_code(e.g.3f2a-bc91) in all error responses (global error handler + auth middleware)POST /client-errorsendpoint for APK crash/error reporting (auth optional)request_idinto audit log entries for all trade state transitions; addGET /audit/lookup?request_id=for support searchFiles changed
Backend (new):
requestId.middleware.ts,client-errors.ts,requestId.test.tsBackend (modified):
index.ts,auth.middleware.ts,audit-log.model.ts,trade.service.ts,trades.tsFrontend (new):
reportError.tsFrontend (modified):
apiError.ts,ErrorBoundary.tsx,CancelTradeDialog.tsx,api.tsMigrations:
audit_log.request_id,client_errorstableTest plan
requestId.test.ts,rateLimit.test.ts)x-request-idheader echoed on all responses (success + error)x-request-idhonored, not overwrittenrequest_id+support_code(auth errors, validation errors, app errors)POST /client-errorsaccepts reports with/without authrequest_idappears in structured backend logs