fix: de-demo success screens and transaction evidence (#79)#98
Open
Zeemnew wants to merge 1 commit into
Open
Conversation
Block success screen when no real activeTrade exists, fetch trade detail from GET /trades/:id for receipt data, source agent name from seller_username instead of hardcoded values, label mock hashes as "Testnet · Simulado", and prevent success navigation on completeTrade failure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@Zeemnew Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Zeemnew
force-pushed
the
fix/79-de-demo-success-screens
branch
from
59afc09 to
6aa2f05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activeTradeexists —id: 'demo'fallback removedGET /trades/:idbefore rendering final screen (real trade ID, backend-confirmed state, lock/release hashes, timestamps)seller_usernameAPI response instead of hardcoded "Farmacia Guadalupe" / "Tienda Don Pepe"MOCK_STELLAR=true— mock hashes don't link to Stellar explorercompleteTradefailure now blocks success navigation and shows error (QRReveal + DepositQR)Test plan
completeTradeand verify the success screen does not appearseller_username, not hardcoded names/successwithout a trade and verify redirect to homeCloses #79