Mark nub and sort functions as INLINE#51
Merged
erikd merged 2 commits intoerikd:masterfrom Feb 5, 2025
Merged
Conversation
Owner
|
Something weird with cabal and tests. I have fixed this on master. Please rebase and force push. |
`nubMutBy` is marked as `INLINABLE`, but change it if `INLINE` is faster
Contributor
Author
|
I've done rebase and force push. Btw the 七味唐がらし made me smile ha ha. |
Contributor
Author
Sounds like too much inlining, as functions called from |
Owner
Where? I have not even seen it. Was not me. |
Contributor
Author
|
Ha ha I saw it in your profile picture (👉 🍶). About this PR,
|
Owner
Ah didn't even know what it was called. I just know I like it on eg Teriaki Chciken. |
Owner
|
I will merge this as is and remove the |
Owner
|
Version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50. Notes:
nubByMutis marked asINLINABLE. Change it toINLINEif it's faster in some case.sortUniqis marked asINLINE, but without any benchmark. I guess it's ok as it's very small.