CommonLib Submodule Update And Potential Compatibility Tweaks#11
Open
Joessarian wants to merge 2 commits intoersh1:masterfrom
Open
CommonLib Submodule Update And Potential Compatibility Tweaks#11Joessarian wants to merge 2 commits intoersh1:masterfrom
Joessarian wants to merge 2 commits intoersh1:masterfrom
Conversation
1. Prevents externally requested actor info bars from being removed by the HUDHandler and delegates their removal to any plugins making use of the TrueHUDAPI. 2. Can now add a boss or actor info bar for player 1 or other actors even when out of combat.
Ignore LOS checks for the player (unnecessary) or externally managed actors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ersh! I wanted to propose a couple of changes with this PR. First time submitting one of these, so please let me know if anything doesn't look right.
Decided to make the changes after attempting to add info bars and having trouble keeping the widgets visible. If the mechanism by which these modifications are delivered does not align with the design of TrueHUD, I'd be happy to consider another method (such as creating new InfoBarsDisplayMode options or locking ownership of an info bar behind a SKSE::PluginHandle-based API request). Also, since Party Combat Parameters hasn't been updated to support AE, I was looking for an alternative to display teammate and player HMS info even when out of combat. In the future, if I were to create a new widget based on the player widget to show teammate HMS info, would adding such a widget be in-scope for TrueHUD? Really enjoying TrueHUD for how seamlessly it fits in with Skyrim's UI and for how customizable it is!