Skip to content

Conversation

@joaopedrodcf
Copy link
Contributor

Adding node-fetch and cross-fetch to the module replacements, with this we have modules that will require the same replacements how should we share that part ? Should we do it like lodash/underscore example ?

I also created issues in the respective repositories as it would be nice to warn users about not needing the modules depending on their engines:
node-fetch/node-fetch#1857
lquixada/cross-fetch#209

Closes #269 #268

@43081j
Copy link
Contributor

43081j commented Dec 26, 2025

i wonder if we should just have a fetch.md which axios, node-fetch and cross-fetch link to.

we generally do one-to-one docs so we can show migration examples (rich diffs). but in this case, there are no diffs, rather just basic examples. so we probably could have one doc

thoughts? would be nice to get the opinion of someone like @outslept or @Fuzzyma too

@Fuzzyma
Copy link
Collaborator

Fuzzyma commented Dec 27, 2025

It depends how the files are consumed but afaik all the markdowns are only redacted and read by people so it doesn't have to follow a strict format.
Therefore it makes sense what @43081j said. We would only repeat ourselves again and again because all the fetch implementations are pretty similar

@43081j
Copy link
Contributor

43081j commented Dec 27, 2025

they ultimately will be synced into the e18e site pretty much. so yes, its just a human readable thing, i.e. nothing programmatically expects any particular structure

if we're all happy having one fetch doc, we should probably unify axios in this PR too (just rename the axios doc to fetch and reword it a bit)

@joaopedrodcf
Copy link
Contributor Author

Okay will do it tomorrow guys 💪

@joaopedrodcf joaopedrodcf force-pushed the add_node_fetch_and_cross_fetch branch from ff3efb4 to be4e0d4 Compare December 30, 2025 22:37
@joaopedrodcf
Copy link
Contributor Author

Sorry for the delay in such a small change is done @43081j and @Fuzzyma

@joaopedrodcf joaopedrodcf force-pushed the add_node_fetch_and_cross_fetch branch from be4e0d4 to c9ec89d Compare January 4, 2026 11:24
@joaopedrodcf
Copy link
Contributor Author

@43081j @Fuzzyma fixed the sorting that was causing the CI to fail, didn't noticed it the other day! :D

@43081j 43081j merged commit 0b50a32 into es-tooling:main Jan 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node-fetch

3 participants