Skip to content

Conversation

@ghostdevv
Copy link

I realised when deploying code that imported module-replacements to Cloudflare that it was reading the manifests from the file system, which of course didn't work. This is the minimum change I could get to instead have the json become javascript without_ removing tshy or introducing a breaking change. I couldn't find if this had been talked about before, so apologies for the impromptu PR

@43081j
Copy link
Contributor

43081j commented Jan 6, 2026

i think this makes sense but it probably needs to happen in the next major since we have the json files in our package exports

maybe you can help me get the new manifest structure over the line in #266 👀

and then the new major would have both

@ghostdevv
Copy link
Author

i think this makes sense but it probably needs to happen in the next major since we have the json files in our package exports

They're still there - from a consumer point this shouldn't be a breaking change as only how the main.ts imports the manifests has changed. Before, read from disk at runtime, now simply imported.

maybe you can help me get the new manifest structure over the line in #266 👀

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants