fix(deps): install @escalated-dev/plugin-sdk via codeload tarball — 114 → 70 TS errors#38
Merged
Merged
Conversation
The plugin bridge / dispatcher / route registrar all import from @escalated-dev/plugin-sdk, which lives at https://github.com/escalated-dev/escalated-plugin-sdk and is not yet published to npm. The package was therefore unresolvable at build time, producing 6 direct TS2307 errors and ~38 cascading implicit-any errors across the bridge code. This commit pins the dep at v0.1.2 (which ships the build/ artifacts in git, ref escalated-plugin-sdk#7 and #8) and uses the codeload tarball URL rather than the github: shorthand. The shorthand triggers an npm 11 bug where the cli spawns the git-prepare child install with both --prefer-offline=false AND --prefer-online=false, which the same cli then rejects as mutually exclusive. Codeload tarball URLs bypass the git- prepare path entirely and install cleanly on every npm version. Effect: tsc --noEmit goes from 114 -> 70 errors. The remaining 70 are real code issues tracked individually in #34.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plugin bridge (
src/bridge/*.ts), dispatcher and route registrar all import from@escalated-dev/plugin-sdk. The package lives at https://github.com/escalated-dev/escalated-plugin-sdk and is not yet published to npm, so it was unresolvable at build time:TS2307: Cannot find module '@escalated-dev/plugin-sdk'TS7006: Parameter implicitly has an 'any' typeand similar across bridge codePin to v0.1.2 of the SDK (escalated-plugin-sdk#7 ships the
build/artifacts in git; #8 drops the prepare hook).Use the codeload tarball URL rather than the
github:shorthand because npm 11 spawns the git-prepare child install with both--prefer-offline=falseAND--prefer-online=falseand then rejects them as mutually exclusive — a known npm regression. Codeload tarball URLs bypass the git-prepare path entirely and install cleanly on every npm version.Effect
tsc --noEmiterrors drop from 114 → 70. The remaining 70 split into real code issues tracked individually in #34:property does not exist) — narrower set than before, no longer cascading fromneverX is unknown)Cannot find module) —#start/env,@adonisjs/transmit/services/main,adm-zipEach will be a focused follow-up PR.
Test plan
rm -rf node_modules/@escalated-dev && npm install— succeeds,node_modules/@escalated-dev/plugin-sdk/build/present with the expected.js+.d.tsfilestsc --noEmiterrors: 114 → 70