Conversation
This change adds a new migration.md file where details about major migrations can be documented. The first section is details about migrating from the previous implementation `eslint-plugin-markdown`.
lumirlumir
left a comment
There was a problem hiding this comment.
Hi @michaelfaith, could you take a look at the CI failures?
The failure related to the Markdown document will be resolved once we add the following line:
<!-- eslint-disable-line -- This should be fixed in https://github.com/eslint/markdown/issues/294 -->
markdown/docs/rules/no-bare-urls.md
Lines 14 to 18 in 868153b
The Bun CI failure should be resolved once #555 is merged.
(If this PR needs to be merged quickly, it can be resolved by adding @types/unist, @types/mdast, and semver to the dev dependencies.)
Thanks! I made those updates |
|
Thanks for the feedback. I believe I've addressed everything. Let me know if there are any other updates you'd recommend. |
docs/migration.md
Outdated
| }, | ||
| extends: ["js/recommended"], | ||
| }, | ||
| markdown.configs.recommended, |
There was a problem hiding this comment.
We're encouraging people to use extends now:
| markdown.configs.recommended, | |
| { | |
| files: ["**/*.md"], | |
| plugins: { | |
| markdown | |
| }, | |
| extends: ["markdown/recommended"] | |
| } |
There was a problem hiding this comment.
Sounds good. And that's the case even for configs that already declare files and plugins in the configs?
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Would like @nzakas and others to verify before merging.
Prerequisites checklist
What changes did you make? (Give an overview)
This change adds a new migration.md file where details about major migrations can be documented. The first section is details about migrating from the previous implementation
eslint-plugin-markdown.fixes #517