Skip to content

fix(uvc): Provide default URB size based on MPS#489

Merged
tore-espressif merged 1 commit into
masterfrom
fix/uvc_urb_sizes
May 6, 2026
Merged

fix(uvc): Provide default URB size based on MPS#489
tore-espressif merged 1 commit into
masterfrom
fix/uvc_urb_sizes

Conversation

@tore-espressif
Copy link
Copy Markdown
Collaborator

Previously we checked user provided URB size against dwMaxPayloadTransferSize. However, some cameras could return unreasonably large or small values, limiting configuration flexibility.
Now we provide a default URB size of 4x MPS, which is a reasonable starting point.

Changes #450

Copy link
Copy Markdown
Collaborator

@TDA-2030 TDA-2030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread host/class/uvc/usb_host_uvc/uvc_host.c
Comment thread host/class/uvc/usb_host_uvc/CHANGELOG.md Outdated
Comment thread host/class/uvc/usb_host_uvc/include/usb/uvc_host.h Outdated
@tore-espressif
Copy link
Copy Markdown
Collaborator Author

@igi540 @TDA-2030 Thank you for your reviews, will fix ASAP!

Previously we checked user provided URB size against dwMaxPayloadTransferSize.
However, some cameras could return unreasonably large or small values,
limiting configuration flexibility.
Now we provide a default URB size of 4x MPS, which is a reasonable starting point.

Changes #450
@tore-espressif tore-espressif added this to the usb_host_uvc 2.5.1 milestone May 6, 2026
@tore-espressif tore-espressif merged commit ae630de into master May 6, 2026
62 checks passed
@tore-espressif tore-espressif deleted the fix/uvc_urb_sizes branch May 6, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants