Skip to content

chore(docs): Update docs to reflect existence of patch.tolerations#175

Open
andrewjeffree wants to merge 1 commit intoestahn:mainfrom
andrewjeffree:imagebumper_chart_documentation
Open

chore(docs): Update docs to reflect existence of patch.tolerations#175
andrewjeffree wants to merge 1 commit intoestahn:mainfrom
andrewjeffree:imagebumper_chart_documentation

Conversation

@andrewjeffree
Copy link

Purpose

Observed today when deploying this that the helm docs nor the values files imply that this is a supported option but it is indeed there inside the patch job definitions.

Changes

  • added patch.tolerations to values.yaml and values.schema.json
  • updated Readme

Testing

Code Author Checklist

  • Bump the chart version (Chart.yaml -> version)
  • JSON Schema updated (values.schema.json)
  • Update README.md via helm-docs (or make prep)
  • Run pre-commit run --all-files via pre-commit (or make prep)
  • Update Artifacthub annotation (Chart.yaml -> artifacthub.io/changes, artifacthub.io/images)

Observed today when deploying this that the helm docs nor the values
files imply that this is a supported option but it is indeed there
inside the patch job definitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant