Skip to content

Attach comments performance#115

Open
mamaniv wants to merge 2 commits intoestools:masterfrom
mamaniv:AttachCommentsPerformance
Open

Attach comments performance#115
mamaniv wants to merge 2 commits intoestools:masterfrom
mamaniv:AttachCommentsPerformance

Conversation

@mamaniv
Copy link

@mamaniv mamaniv commented Jul 23, 2020

Increase cursor instead of using splice on comments array, which is a very expensive operation and cause a performance issue for large files with many comments.

closes #114

michaelficarra and others added 2 commits July 23, 2020 16:39
… very expensive operation and cause a performance issue for large files with many comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance issue with attachComments

2 participants