Refactor: remove dead code and deduplicate httpserver helpers#49
Merged
Conversation
- Remove stale internal/db package (unused sqlc output with outdated schema) - Consolidate duplicated validateCredentials / validateCredentialsIncludingInactive into shared doValidateCredentials with a function parameter - Consolidate duplicated getUserFromSession / getUserFromSessionIncludingInactive into shared doGetUserFromSession with a function parameter - Extract duplicated OAuth client authentication into authenticateClient, used by token, refresh, introspect, and revoke handlers - Consolidate four identical JSON error writers (writeTokenError, writeIntrospectError, writeRevokeError, writeAdminError) into shared writeJSONError - Consolidate duplicated CORS middleware into parameterized newCorsMiddleware factory - Replace manual URL string concatenation in HandleRegisterPost with url.Values (resolves existing TODO) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/dbpackage (unused sqlc output with outdated schema — 589 lines of dead code)validateCredentials/validateCredentialsIncludingInactiveinto a shareddoValidateCredentialswith a function parameter for the DB querygetUserFromSession/getUserFromSessionIncludingInactiveinto a shareddoGetUserFromSessionwith a function parameterauthenticateClient, used by token, refresh, introspect, and revoke handlerswriteTokenError,writeIntrospectError,writeRevokeError,writeAdminError) into a sharedwriteJSONErrorfunctioncorsMiddleware,oauthCorsMiddleware) into a parameterizednewCorsMiddlewarefactoryHandleRegisterPostwithurl.Values(resolves existing TODO)Net change: -678 lines (103 added, 781 removed)
Test plan
go build ./...passesgo vet ./...passesgo test ./...— integration tests require Docker, unrelated to this change)🤖 Generated with Claude Code