fix: stop pinning staging to :latest (image-updater allow-tags)#81
Merged
Conversation
image-updater (newest-build, no tag filter) ties `latest` against the
newest `{sha}` tag — both pushed for the same image at the same build
time — and resolves the tie to `:latest`, so staging runs `:latest`
forever instead of a real SHA. Add an allow-tags filter restricting
candidates to SHA tags, matching forecasting/bifrost. Staging-only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
argocd-image-updateris configured withupdate-strategy: newest-buildand no tag filter. Cloud Build pushes both$SHORT_SHAandlatestfor the same image (same digest, same build time), so when image-updater resolves the "newest build" it ties betweenlatestand the newest{sha}tag and pickslatest— pinning the staging Application'skustomize.imagesto...:latest.As a result staging perpetually runs
:latestinstead of a real SHA, and the bifrost deploy dashboard reports this service's staging as "unknown" (an unparseable tag).Fix
Add an
allow-tagsregexp restricting candidate tags to immutable SHA tags (^[a-f0-9]{7,}$), excludinglatest. image-updater then always pins the newest{sha}tag. This mirrors the working config already onforecastingandbifrost.Staging-only; prod has no image-updater and is unaffected. After merge, re-apply the Application for it to take effect:
🤖 Generated with Claude Code