feat: add output matching metrics for execution and proving processes#287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
output_matchedflag to successful execution and proving metrics so benchmark results can distinguish performance success from public-output correctness.execution.success.output_matchedfor execute runs.proving.success.output_matchedfor prove runs, requiring both prover and verifier public outputs to match.output_matched: false.To be clear: before this PR, when the received guest program output wasn't what we expected, we halted the whole fixtures run. Now we aren't strict on that front and consider
successto refer to the guest program run, with the newoutput_matchedfield indicating correctness! If the guest program crashes, we still get teh"crashed"variant as usual.Example new fixture result: