Open
Conversation
RMeli
approved these changes
Mar 13, 2026
Member
RMeli
left a comment
RMeli
left a comment
There was a problem hiding this comment.
I'm not familiar with the uenv internals, but the changes and tests LGTM on the surface.
| (char*)"disable default views: only views explicitly set using the --view " | ||
| "flag will be used", | ||
| 0, // does not take an argument | ||
| 0, // plugin specific value to pass to the callback (unnused) |
Member
There was a problem hiding this comment.
Suggested change
| 0, // plugin specific value to pass to the callback (unnused) | |
| 0, // plugin specific value to pass to the callback (unused) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support default views in uenv.
To enable a default view in a uenv the
default-viewfield must be set in themeta/env.jsonfile: this makes default views strictly opt-in.Stackinator gains support for specifying a default view when building a uenv.
This means that existing uenv will not load default views, so users will see no change with existing workflows.