Fix warnings and make more Perlish#1
Open
choroba wants to merge 2 commits into
Open
Conversation
- $inches declared two times - == used instead of = (2x) - wrong case in file name (might have worked on OS or FS that's case insensitive, but on Linux, that's usually not the case)
- Don't use comments that describe the code, - Use three argument "open" with lexical filehandles, - You can read all the lines from a file into an array at once (but your files contain just one line anyway), - JSON is JSON, not Data::Dumper, - Keep DRY (Don't Repeat Yourself), - First argument to "split" is a regex, not a string, - Use regular expressions instead of long list of "index" calls - Be declarative, keep data in structures rather than in code - Etc. Good luck!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👍