Fix regular expression for compactability#127
Open
SamarthJ2004 wants to merge 1 commit intoethereum:masterfrom
Open
Fix regular expression for compactability#127SamarthJ2004 wants to merge 1 commit intoethereum:masterfrom
SamarthJ2004 wants to merge 1 commit intoethereum:masterfrom
Conversation
SamWilsn
requested changes
Oct 14, 2025
Comment on lines
+138
to
142
| if link.title.is_empty() { | ||
| println!("Skipping autolink: {}", link.url); | ||
| return Ok(Next::SkipChildren); | ||
| } | ||
| self.check(ast, &link.title) |
Contributor
There was a problem hiding this comment.
Hm, this doesn't make sense. If the title is empty, check won't return any matches.
| .deny( | ||
| "markdown-re", | ||
| Regex { | ||
| message: "boop", |
Contributor
There was a problem hiding this comment.
"boop" doesn't appear in https://example.com, so this test doesn't actually make sure that autolinks aren't checked for matches. You need to make sure that, before your fix, the test fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Issue Associated #91