execution-spec-tests runners #4207
Open
+497
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
📦 Bundle Size Analysis
Generated by bundle-size workflow |
ScottyPoi
force-pushed
the
execution-specs
branch
from
802f31e to
a3d7656
Compare
ScottyPoi
force-pushed
the
execution-specs
branch
from
5c944c9 to
64f3597
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a comprehensive test runner infrastructure for the execution-spec-tests suite, enabling validation of EthereumJS implementations against the official Ethereum test fixtures. Additionally, it includes critical bug fixes for blob gas calculations and transaction validation.
Key changes:
- New test infrastructure for running state_tests and blockchain_tests from the execution-spec-tests submodule
- Bug fix for EIP-7819: Corrected blob gas price calculation at hardfork transitions to use child common instead of parent common
- Bug fix for transaction gas limit validation: Removed incorrect elasticity multiplier from block gas limit comparison
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/vm/test/tester/executionSpecTestLoader.ts | Implements test fixture loader with support for custom hardfork schedules and transition forks |
| packages/vm/test/tester/executionSpecState.test.ts | State test runner that validates pre-state, transaction execution, and post-state root |
| packages/vm/test/tester/executionSpecBlockchain.test.ts | Blockchain test runner with block processing and exception validation |
| packages/vm/vitest.config.browser.mts | Excludes new execution-spec test files from browser tests |
| packages/block/src/header/header.ts | Fixes EIP-7819 blob fee calculation to use child common at transitions |
| packages/vm/src/runBlock.ts | Corrects transaction gas limit validation against block gas limit |
| packages/block/src/block/block.ts | Updates to use getBlobGasSchedule() API for BPO fork compatibility |
| packages/tx/src/4844/tx.ts | Improves error messages and restructures blob limit validation logic |
| packages/tx/test/eip4844.spec.ts | Updates test assertions to match new error message formats |
| packages/common/src/hardforks.ts | Adds EIP-7892 to Osaka hardfork configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| } | ||
|
|
||
| // // Check final state after all blocks are processed |
There was a problem hiding this comment.
The commented-out line suggests this was previously uncommented code. If the check for final state after all blocks is important, this should be restored or removed. Leaving commented code can reduce maintainability.
Suggested change
| // // Check final state after all blocks are processed |
added 19 commits
December 12, 2025 15:26
ScottyPoi
force-pushed
the
execution-specs
branch
from
64f3597 to
8de1189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a minimal test runner to run
state_testsandblockchain_testsfromexecution-spec-testssubmodule.Includes:
executionSpecTestLoader.tsethereum-spec-testsor a specified subdirectoryTEST_PATHto specify specific test directorycommonfor blockchain teststimestampsetHardforkBybehaviorexecutionSpecState.test.tsexecutionSpecBlockchain.test.tslastBlockhashAdditional:
commonto calculateblobFeecommon(and parentexcessBlobGas) to calculateblobFeethis.gasLimit * elasticityMultiplieras the comparison.this.gasLimitgetBlobGasSchedule().maxBlobGasPerBlockinstead ofparam('maxBlobGasPerBlock')Instructions:
From
packages/evm:npx vitest executionSpecState.test.tsTo run all tests in state_test directories in the
execution-spec-testssubmoduleor
npx vitest executionSpecBlockchain.test.tsTo run all tests in blockchain_test directories in the
execution-spec-testssubmoduleTo run a subset of test, pass in a directory path with env variable
TEST_PATHe.g.
TEST_PATH=../execution-spec-tests/fusaka-devnet-5/blockchain_tests/osaka/eip7918_blob_reserve_price npx vitest test/tester/executionSpecBlockchain.test.ts