refactor: improve architecture and documentation#1
Merged
Conversation
Validate configuration values close to input and narrow fetcher rescue behavior so programmer errors are not hidden. Add crawler-level failure pages for per-URL fetch exceptions. Move shared Rake task execution into Crawlscope::RakeTasks, clarify task descriptions, and document REPORT_PATH as trusted operator input. Refactor the links rule into named extraction and target-resolution steps, and make sitemap structured data validation report missing JSON-LD or microdata with an actionable message. Tests: bundle exec rake test; RUBOCOP_CACHE_ROOT=/tmp/rubocop-cache bundle exec standardrb
fidalgo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test
Release notes
Does this change need an explicit changelog or release-note callout beyond the PR title?
Checklist
About the maintainers
Built by Ethos Link, the team behind Reviato.
Capture. Interpret. Act.
Turn guest feedback into clear next steps for your team. Collect private appraisals, spot patterns across reviews, and act before small issues turn into public ones.