Use storage for sitemaps#12
Merged
Merged
Conversation
Replace the public_path-based API with a single storage abstraction used by sitemap creation, formatting, validation, parsing, Google submission, IndexNow submission, and IndexNow key-file management. Add filesystem, memory, and optional Active Storage adapters. The Active Storage adapter does not add activestorage as a gem dependency; it only uses the model and attachment object supplied by the host application. BREAKING CHANGE: config.public_path has been removed. Configure config.storage instead. BREAKING CHANGE: config.index_now.key_path has been replaced by config.index_now.key_filename, and key files are read and written through configured storage. BREAKING CHANGE: Indexmap::Parser now accepts source: instead of path:.
Preserve relative sitemap storage keys instead of reducing them to basenames when parsing and validating local sitemap files. Resolve relative child sitemap locations from their parent sitemap directory so prefixed keys such as sitemaps/sitemap.xml keep working across storage backends. Pass the XML content type when the format task rewrites sitemap files, keeping the documented custom storage write(filename, body, content_type:) interface valid. List nested sitemap files from filesystem storage, keep IndexNow filtering aligned with configured index filenames, and add regression coverage for parser, validator, format, filesystem storage, and IndexNow behavior. Document the upgrade path in UPGRADE.md with development and production verification steps, and link it from the README for existing applications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test
Release notes
Does this change need an explicit changelog or release-note callout beyond the PR title?
Checklist
About the maintainers
Built by Ethos Link, the team behind Reviato.
Capture. Interpret. Act.
Turn guest feedback into clear next steps for your team. Collect private appraisals, spot patterns across reviews, and act before small issues turn into public ones.